Web lists-archives.com

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name




Shulhan <m.shulhan@xxxxxxxxx> writes:

> When adding new remote name with empty string, git will print the
> following error message,
>
>   fatal: '' is not a valid remote name\n
>
> But when removing remote name with empty string as input, git shows the
> empty string without quote,
>
>   fatal: No such remote: \n
>
> To make these error messages consistent, quote the name of the remote
> that we tried and failed to find.
>
> Signed-off-by: Shulhan <m.shulhan@xxxxxxxxx>
> Reviewed-by: Junio C Hamano <gitster@xxxxxxxxx>
> ---
>  builtin/remote.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Have you run "make test" with this change?  

I expect at least 5505.10 to fail without adjustment.