Re: [PATCH v4] http-backend: allow empty CONTENT_LENGTH
- Date: Mon, 10 Sep 2018 14:46:19 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH v4] http-backend: allow empty CONTENT_LENGTH
On Mon, Sep 10, 2018 at 09:37:20AM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
> > But that couldn't have been what older versions were doing, since they
> > never looked at CONTENT_LENGTH at all, and instead always read to EOF.
> > So presumably the original problem wasn't that we tried to read a body,
> > but that the empty string caused git_parse_ssize_t to report failure,
> > and we called die(). Which probably should be explained by 574c513e8d
> > (http-backend: allow empty CONTENT_LENGTH, 2018-09-07), but it's too
> > late for that.
> > So after that patch, we really do have the original behavior, and that's
> > enough for v2.19.
> To recap to make sure I am following it correctly:
> - pay attention to content-length when it is clearly given with a
> byte count, which is an improvement over v2.18
> - mimick what we have been doing until now when content-length is
> missing or set to an empty string, so we are regression free and
> bug-to-bug compatible relative to v2.18 in these two cases.
That (and what you wrote below) matches my current understanding, too.
Though I did already admit to being confused. ;)