Web lists-archives.com

Re: [PATCH 0/2] Fixup for js/mingw-o-append

GitGitGadget botched the CCs when I submitted this.
Replying here to add them.



On 9/7/2018 2:19 PM, Jeff Hostetler via GitGitGadget wrote:
The recent change mingw O_APPEND change breaks writing to named pipes on
Windows. The first commit adds a new test to confirm the breakage and the
second commit fixes the problem. These could be squashed together or we can
just keep the fix and omit the test if that would be better.

d641097589 (js/mingw-o-append) mingw: enable atomic O_APPEND

The new mingw_open_append() routine successfully opens the client side of
the named pipe, but the first write() to it fails with EBADF. Adding the
FILE_WRITE_DATA corrects the problem.

  Signed-off-by: Jeff Hostetler jeffhost@xxxxxxxxxxxxx

Cc: j6t@kdbg.orgCc: johannes.schindelin@xxxxxxxx: gitster@pobox.comCc:

Jeff Hostetler (2):
   t0051: test GIT_TRACE to a windows named pipe
   mingw: fix mingw_open_append to work with named pipes

  Makefile                           |  1 +
  compat/mingw.c                     |  2 +-
  t/helper/test-tool.c               |  3 ++
  t/helper/test-tool.h               |  3 ++
  t/helper/test-windows-named-pipe.c | 72 ++++++++++++++++++++++++++++++
  t/t0051-windows-named-pipe.sh      | 17 +++++++
  6 files changed, 97 insertions(+), 1 deletion(-)
  create mode 100644 t/helper/test-windows-named-pipe.c
  create mode 100755 t/t0051-windows-named-pipe.sh

base-commit: d641097589160eb795127d8dbcb14c877c217b60
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-35%2Fjeffhostetler%2Ffixup-mingw-o-append-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-35/jeffhostetler/fixup-mingw-o-append-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/35