Re: [PATCH 1/2] commit-graph write: add progress output
- Date: Fri, 7 Sep 2018 09:12:12 -0400
- From: Derrick Stolee <stolee@xxxxxxxxx>
- Subject: Re: [PATCH 1/2] commit-graph write: add progress output
On 9/7/2018 8:40 AM, Ævar Arnfjörð Bjarmason wrote:
Good catch! (I do want to clarify that the graph _writing_ happens
during 'git gc' since 'git commit-graph verify' is a different thing.)
On Tue, Sep 04 2018, Ævar Arnfjörð Bjarmason wrote:
Before this change the "commit-graph write" command didn't report any
progress. On my machine this command takes more than 10 seconds to
write the graph for linux.git, and around 1m30s on the
2015-04-03-1M-git.git test repository, which is a test case for
There's a fun issue with this code that I'll fix, but thought was
informative to send a mail about.
Because the graph verification happens in the main "git gc" process, as
opposed to everything else via external commands, so all this progress
output gets written to .git/gc.log.
Then next time we do a "gc --auto" we vomit out a couple of KB of
progress bar output at the user, since spot that the gc.log isn't empty.