Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases
- Date: Thu, 6 Sep 2018 16:50:33 -0700
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases
Jeff King wrote:
> But what I think is harmful is a _sorted_ list, because of the
> "accidentally quadratic" nature, and because it's easy to call its
> functions on an unsorted list.
I agree --- in general, it tends to be better to build an unsorted
string list and then sort it.
Once I've done so, what is your advice about getting fast lookups
in the result? Should I build an auxiliary hashmap as well? Or
is this an argument for the 'sorted' flag + BUG approach you
Whatever we do, I agree with your goal of getting rid of