Re: [RFC PATCH v2] Allow aliases that include other aliases
- Date: Wed, 05 Sep 2018 14:51:09 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [RFC PATCH v2] Allow aliases that include other aliases
Jeff King <peff@xxxxxxxx> writes:
>> This is what I've come up with to prevent looping aliases. I'm not too
>> happy with the number of indentations needed, but this seemed to be the
>> easiest way to search an array for a value.
> I think this approach is OK, though I wonder if we'd also be fine with
> if (done_alias++ > 100)
> die("woah, is your alias looping?");
> The point is just to prevent a runaway infinite loop, and this does that
> while keeping the cost very low for the common case (not that one string
> insertion is probably breaking the bank).
Yeah, as a hack, I guess the simpler the solution, the better it