Web lists-archives.com

Re: [PATCH 01/11] multi-pack-index: add 'verify' verb




On 9/5/2018 2:59 PM, Eric Sunshine wrote:
On Wed, Sep 5, 2018 at 10:46 AM Derrick Stolee via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
The multi-pack-index builtin writes multi-pack-index files, and
uses a 'write' verb to do so. Add a 'verify' verb that checks this
file matches the contents of the pack-indexes it replaces.
[...]
Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
---
diff --git a/builtin/multi-pack-index.c b/builtin/multi-pack-index.c
@@ -5,7 +5,7 @@
  static char const * const builtin_multi_pack_index_usage[] = {
-       N_("git multi-pack-index [--object-dir=<dir>] write"),
+       N_("git multi-pack-index [--object-dir=<dir>] [write|verify]"),
Nit: The square brackets make the verb optional. You probably want
parenthesis to indicate that one or the other is required:

     git multi-pack-index [--object-dir=<dir>] (write|verify)
Thanks for catching this mistake! This would be easy to miss and keep around forever.