Re: [PATCH] sha1-name.c: for ":/", find detached HEAD commits
- Date: Wed, 11 Jul 2018 09:34:52 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] sha1-name.c: for ":/", find detached HEAD commits
Jeff King <peff@xxxxxxxx> writes:
> On Tue, Jul 10, 2018 at 11:18:22PM -0700, William Chargin wrote:
>> > Also, I am not sure if "or from HEAD" is even needed when we say
>> > "from ANY ref" already, as we count things like HEAD as part of the
>> > ref namespace.
>> My two cents: with the docs as is, I wasn't sure whether HEAD was
>> intended to count as a ref for this purpose. The gitglossary man page
>> defines a ref as a "name that begins with refs/" (seemingly excluding
>> HEAD), though it later says that HEAD is a "special-purpose ref". In my
>> opinion, the change adds clarity without any particular downside---but
>> I'm happy to revert it if you'd prefer. I'd also be happy to change the
>> wording to something like "any ref, including HEAD" if we want to
>> emphasize that HEAD really is a ref.
> FWIW, I think the clarification to include HEAD is helpful here, since
> it took me a few minutes of thinking to decide whether the current
> behavior was a bug or just a subtlety. Your "including HEAD" suggestion
> seems like the best route to me. But I can live with it either way.
>> After reaching consensus on the change to the docs, should I send in a
>> [PATCH v2] In-Reply-To this thread?
>> Peff, should I add your
>> Signed-off-by to the commit message, or is that not how things are done?
> Yes, you can add in any sign-offs that have been explicitly given. It's
> normal to order them chronologically, too (so mine would come first,
> then yours, showing that the patch flowed through me to you; Junio will
> add his at the end).
Thanks, agreed 100% and I have nothing more to add.