Web lists-archives.com

Re: [PATCH 0/6] Compile cleanly in pedantic mode




Hi Junio

Am 09.07.2018 23:45, schrieb Junio C Hamano:
Beat Bolli <dev+git@xxxxxxxxx> writes:

While developing 6aaded550 ("builtin/config: work around an unsized
array forward declaration", 2018-07-05), I have compiled Git with
CFLAGS="-std=c99 -pedantic".

Nicely done.

With these 6 patches and the USE_PARENCE_AROUND_GETTEXT_N hack, the
forward decl of the unsized static array you dealt with separately
becomes the only remaining violation in the codebase, which is good.

Will queue.  Thanks.

Should we add a "pedantic" flag to DEVOPTS that would simplify building pedantically? It would also have to set USE_PARENS_AROUND_GETTEXT_N so as to not overwhelm the developer with too much output.

Beat