Web lists-archives.com

Re: [PATCH v1 1/2] convert: refactor conversion driver config parsing




Lars Schneider <larsxschneider@xxxxxxxxx> writes:

>> On Jul 8, 2018, at 8:30 PM, larsxschneider@xxxxxxxxx wrote:
>> 
>> From: Lars Schneider <larsxschneider@xxxxxxxxx>
>> 
>> Refactor conversion driver config parsing to ease the parsing of new
>> configs in a subsequent patch.
>> 
>> No functional change intended.
>> 
>> Signed-off-by: Lars Schneider <larsxschneider@xxxxxxxxx>
>> ---
>> convert.c | 64 +++++++++++++++++++++++++++----------------------------
>> 1 file changed, 32 insertions(+), 32 deletions(-)
>> 
>> diff --git a/convert.c b/convert.c
>> index 64d0d30e08..949bc783e4 100644
>> --- a/convert.c
>> +++ b/convert.c
>> @@ -1003,43 +1003,43 @@ static int read_convert_config(const char *var, const char *value, void *cb)
>> 	int namelen;
>> 	struct convert_driver *drv;
>> 
>> ...
>> 
>> -	/*
>> -	 * filter.<name>.smudge and filter.<name>.clean specifies
>> -	 * the command line:
>> -	 *
>> -	 *	command-line
>> -	 *
>> -	 * The command-line will not be interpolated in any way.
>> -	 */
>> +		/*
>> +		 * filter.<name>.smudge and filter.<name>.clean specifies
>> +		 * the command line:
>> +		 *
>> +		 *	command-line
>> +		 *
>> +		 * The command-line will not be interpolated in any way.
>> +		 */
>
> I stumbled over this comment introduced in aa4ed402c9 
> ("Add 'filter' attribute and external filter driver definition.", 2007-04-21).
>
> Is the middle "command-line" intentional?

I think it was a deliberate but ineffective attempt to emphasize the
fact that the command line is used as-is, and does not get split at
SP nor goes through interpolation of placeholders using API such as
strbuf_expand().