Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob
- Date: Mon, 09 Jul 2018 12:33:01 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob
Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes:
> When cloning a repository with a tagged blob (like the Git repository)
> with --filter=blob:none, the following message appears:
> error: missing object referenced by 'refs/tags/junio-gpg-pub'
> and the resulting repository also fails fsck.
> Patch 1 fixes the protocol documentation and the server side of Git, and
> patch 2 makes clone error out when such a situation occurs.
> An argument could be made that we should not merge patch 2 just yet due
> to the fact that some server implementations (such as Git and JGit)
> still exhibit the old behavior, and the resulting clones (albeit failing
> fsck) are still usable, because when attempting to load the blob, Git
> will automatically fetch it. I'm on the fence about this, and have
> included patch 2 in this patch set nevertheless for completeness.
I think the latter is probably a good thing to nudge the server
implementations in the right direction by gently poking them ;-)
The patches textually apply cleanly on 'master' but apparently it
needs some fixes in jt/partial-clone-fsck-connectivity topic to