Re: [PATCH 00/17] object_id part 14
- Date: Sun, 8 Jul 2018 20:12:54 -0700
- From: Jacob Keller <jacob.keller@xxxxxxxxx>
- Subject: Re: [PATCH 00/17] object_id part 14
On Sun, Jul 8, 2018 at 4:39 PM brian m. carlson
> This is the fourteenth series of patches to switch to using struct
> object_id and the_hash_algo. This series converts several core pieces
> to use struct object_id, including the oid* and hex functions.
> All of these patches have been tested with both SHA-1 and a 256-bit
I read through the series, and didn't spot anything odd, except for
the question about reasoning for why we use memcmp directly over using
hashcmp. I don't think that's any sort of blocker, it just seemed an
odd decision to me.