Web lists-archives.com

Re: [RFC PATCH 4/6] sequencer.c: avoid empty statements at top level




From: "Eric Sunshine" <sunshine@xxxxxxxxxxxxxx>
To: "Beat Bolli" <dev+git@xxxxxxxxx>
On Sun, Jul 8, 2018 at 10:44 AM Beat Bolli <dev+git@xxxxxxxxx> wrote:
The marco GIT_PATH_FUNC expands to a complete statement including the

s/marco/macro/

semicolon. Remove two extra trailing semicolons.

Signed-off-by: Beat Bolli <dev+git@xxxxxxxxx>
---
 sequencer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

While you're at it, perhaps it would be a good idea to fix the example
in path.h which teaches the "wrong" way:

/*
* You can define a static memoized git path like:
*
*    static GIT_PATH_FUNC(git_path_foo, "FOO");
*
* or use one of the global ones below.
*/