Web lists-archives.com

Re: [PATCH 1/3] send-email: add an auto option for transfer encoding




On Fri, Jul 06, 2018 at 02:01:25AM -0400, Eric Sunshine wrote:
> On Thu, Jul 5, 2018 at 10:24 PM brian m. carlson
> <sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
> > For most patches, using a transfer encoding of 8bit provides good
> > compatibility with most servers and makes it as easy as possible to view
> > patches.  However, there are some patches for which 8bit is not a valid
> > encoding: RFC 5321 specifies that a message must not have lines
> > exceeding 998 octets.
> >
> > Add a transfer encoding value, auto, which indicates that a patch should
> > use 8bit where allowed and quoted-printable otherwise.  Choose
> > quoted-printable instead of base64, since base64-encoded plain text is
> > treated as suspicious by some spam filters.
> >
> > Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > @@ -1852,13 +1851,16 @@ sub apply_transfer_encoding {
> > +       $to = ($message =~ /.{999,}/) ? 'quoted-printable' :'8bit'
> > +               if $to eq 'auto';
> 
> Style: space after colon: 'quoted-printable' : '8bit'

Will fix.

> > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> > +test_expect_success $PREREQ 'long lines with auto encoding are quoted-printable' '
> > +       clean_fake_sendmail &&
> > +       git send-email \
> > +               --from="Example <nobody@xxxxxxxxxxx>" \
> > +               --to=nobody@xxxxxxxxxxx \
> > +               --smtp-server="$(pwd)/fake.sendmail" \
> > +               --transfer-encoding=auto \
> > +               --no-validate \
> > +               longline.patch \
> > +               2>errors &&
> 
> Why capture stderr to a file then ignore the file?

Copy-paste error from an earlier test.  Will fix.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

Attachment: signature.asc
Description: PGP signature