Re: [GSoC][PATCH v2 3/7] editor: add a function to launch the sequence editor
- Date: Tue, 03 Jul 2018 13:32:45 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [GSoC][PATCH v2 3/7] editor: add a function to launch the sequence editor
Alban Gruin <alban.gruin@xxxxxxxxx> writes:
> As part of the rewrite of interactive rebase, the sequencer will need to
> open the sequence editor to allow the user to edit the todo list.
> Instead of duplicating the existing launch_editor() function, this
> refactors it to a new function, launch_specified_editor(), which takes
> the editor as a parameter, in addition to the path, the buffer and the
> environment variables. launch_sequence_editor() is then added to launch
> the sequence editor.
> Signed-off-by: Alban Gruin <alban.gruin@xxxxxxxxx>
Looks the same from the previous round, and the changes look good.
You can say "Unchanged from what has been queued on 'pu'" or
somesuch to save reviewer's time after the line with three-dashes