Web lists-archives.com

Re: [PATCH 04/25] t: drop unnecessary terminating semicolon in subshell




Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:

> Signed-off-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
> ---
>  t/t3102-ls-tree-wildcards.sh    | 2 +-
>  t/t4010-diff-pathspec.sh        | 4 ++--
>  t/t9400-git-cvsserver-server.sh | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/t/t3102-ls-tree-wildcards.sh b/t/t3102-ls-tree-wildcards.sh
> index e804377f1c..1e16c6b8ea 100755
> --- a/t/t3102-ls-tree-wildcards.sh
> +++ b/t/t3102-ls-tree-wildcards.sh
> @@ -23,7 +23,7 @@ test_expect_success 'ls-tree outside prefix' '
>  	cat >expect <<-EOF &&
>  	100644 blob $EMPTY_BLOB	../a[a]/three
>  	EOF
> -	( cd aa && git ls-tree -r HEAD "../a[a]"; ) >actual &&
> +	( cd aa && git ls-tree -r HEAD "../a[a]" ) >actual &&
>  	test_cmp expect actual
>  '

Nice clean-up.  

I still find it irritating that ( ...; ) is merely unnecessary but
not incorrect, while lack of semicolon in { ...; } is a hard error
;-)