Web lists-archives.com

Re: [PATCH 06/23] builtin/pack-objects.c: mark more strings for translation




On Sat, Jun 30, 2018 at 2:08 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> Most of these are straight forward. GETTEXT_POISON does catch the last
> string in cmd_pack_objects(), but since this is --progress output, it's
> not supposed to be machine-readable.
>

> @@ -2341,8 +2342,8 @@ static void ll_find_deltas(struct object_entry **list, unsigned list_size,
>                 return;
>         }
>         if (progress > pack_to_stdout)
> -               fprintf_ln(stderr, "Delta compression using up to %d threads.",
> -                               delta_search_threads);
> +               fprintf_ln(stderr, _("Delta compression using up to %d threads"),
> +                          delta_search_threads);

Full stop removal that probably belongs in patch 1 instead.

>         if (!pack_to_stdout && !pack_size_limit)
>                 pack_size_limit = pack_size_limit_cfg;
>         if (pack_to_stdout && pack_size_limit)
> -               die("--max-pack-size cannot be used to build a pack for transfer.");
> +               die(_("--max-pack-size cannot be used to build a pack for transfer"));

same.

>         if (keep_unreachable && unpack_unreachable)
> -               die("--keep-unreachable and --unpack-unreachable are incompatible.");
> +               die(_("--keep-unreachable and --unpack-unreachable are incompatible"));

same.

>         if (filter_options.choice) {
>                 if (!pack_to_stdout)
> -                       die("cannot use --filter without --stdout.");
> +                       die(_("cannot use --filter without --stdout"));

same.