Web lists-archives.com

Re: [PATCHv2 0/6] git-p4: some small fixes updated




On 12 June 2018 at 22:35, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Luke Diamand <luke@xxxxxxxxxxx> writes:
>
>> On 12 June 2018 at 18:10, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> Luke Diamand <luke@xxxxxxxxxxx> writes:
>>>
>>>> This is an updated version of the set of changes I posted recently,
>>>> following comments on the list:
>>>>
>>>> disable automatic sync after git-p4 submit:
>>>>     https://marc.info/?l=git&m=152818734814838&w=2
>>>>
>>>> better handling of being logged out by Perforce:
>>>>    https://marc.info/?l=git&m=152818893815326&w=2
>>>>
>>>> adapt the block size automatically on git-p4 submit:
>>>>    https://marc.info/?l=git&m=152819004315688&w=2
>>>>
>>>> - Spelling corrections (Eric)
>>>> - Improved comments (Eric)
>>>> - Exception class hierarchy fix (Merland)
>>>> - test simplification (Eric)
>>>>
>>>
>>> That reminds me of one thing.
>>>
>>> This 6-patch series depends on the rm/p4-submit-with-commit-option
>>> that came without and still waiting for a sign-off by the original
>>> author.  Also I do not think the original patch reached the public
>>> list, so I'm attaching the patch to make sure people know which
>>> patch I am talking about.
>>>
>>> Romain, can we get your sign-off on the patch you sent earlier?
>>
>> Wasn't it already sent in this message:
>>
>> https://marc.info/?l=git&m=152783923418317&w=2
>>
>> Luke
>
>
> Thanks for a pointer.  Will replace and requeue.

Thanks. While on the subject of git-p4, I thought I should mention
that I've been looking at getting git-p4 to work with Python3.

I've got some low risk easy (mostly automated) changes which get it to
the point where it compiles. After that I have to figure out how to
fix the byte-vs-string unicode problem that Python3 brings. Having
been playing around with it, I think it should be possible to make the
same git-p4.py script work with 2.7, 3.6 and probably 2.6, although
I'm still some way from making this last bit work.

Luke