Web lists-archives.com

Re: [PATCHv2 0/6] git-p4: some small fixes updated




Luke Diamand <luke@xxxxxxxxxxx> writes:

> On 12 June 2018 at 18:10, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Luke Diamand <luke@xxxxxxxxxxx> writes:
>>
>>> This is an updated version of the set of changes I posted recently,
>>> following comments on the list:
>>>
>>> disable automatic sync after git-p4 submit:
>>>     https://marc.info/?l=git&m=152818734814838&w=2
>>>
>>> better handling of being logged out by Perforce:
>>>    https://marc.info/?l=git&m=152818893815326&w=2
>>>
>>> adapt the block size automatically on git-p4 submit:
>>>    https://marc.info/?l=git&m=152819004315688&w=2
>>>
>>> - Spelling corrections (Eric)
>>> - Improved comments (Eric)
>>> - Exception class hierarchy fix (Merland)
>>> - test simplification (Eric)
>>>
>>
>> That reminds me of one thing.
>>
>> This 6-patch series depends on the rm/p4-submit-with-commit-option
>> that came without and still waiting for a sign-off by the original
>> author.  Also I do not think the original patch reached the public
>> list, so I'm attaching the patch to make sure people know which
>> patch I am talking about.
>>
>> Romain, can we get your sign-off on the patch you sent earlier?
>
> Wasn't it already sent in this message:
>
> https://marc.info/?l=git&m=152783923418317&w=2
>
> Luke


Thanks for a pointer.  Will replace and requeue.