Re: [GSoC][PATCH 1/1] rebase--interactive: rewrite the edit-todo functionality in C
- Date: Tue, 12 Jun 2018 14:33:02 +0200
- From: Alban Gruin <alban.gruin@xxxxxxxxx>
- Subject: Re: [GSoC][PATCH 1/1] rebase--interactive: rewrite the edit-todo functionality in C
Le 11/06/2018 à 17:32, Phillip Wood a écrit :
>> + if (launch_editor(todo_file, NULL, NULL))
> I'm not sure that this will respect GIT_SEQUENCE_EDITOR, it would be
> nice to have a launch_sequence_editor() function that shared as much
> code as possible with launch_editor()
It could be done by making launch_editor() and launch_sequence_editor()
some kind of wrapper around a function like launch_specified_editor()
(or something like that), that would take the editor as a parameter, in
addition to the path, the buffer and environment variables. It would be
also very trivial to implement your first point above on top of that.
>> int append_todo_help(unsigned edit_todo, unsigned keep_empty);
> Can this declaration be removed now?
No, it’s still used in rebase--helper.c for now.
>> +int edit_todo_list(unsigned flags);
>> int skip_unnecessary_picks(void);
>> int rearrange_squash(void);
> Best Wishes