Re: [PATCH 1/2] pack-bitmap: remove bitmap_git global variable
- Date: Mon, 11 Jun 2018 17:10:34 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 1/2] pack-bitmap: remove bitmap_git global variable
On Mon, Jun 11, 2018 at 11:50:46AM -0700, Jonathan Tan wrote:
> Here's an paragraph to be added to the end of the commit message. I can
> send a reroll with the exact same code but with the updated commit
> message if Junio requests it.
> [additional paragraph begin]
> This patch raises two potential issues: (1) memory for the struct
> bitmap_index is allocated without being freed, and (2)
> prepare_bitmap_git() and prepare_bitmap_walk() can reuse a previously
> loaded bitmap. For (1), this will be dealt with in a subsequent patch in
> this patch set that also deals with freeing the contents of the struct
> bitmap_index (which were not freed previously, because they have global
> scope). For (2), current bitmap users only load the bitmap once at most
> (note that pack-objects can use bitmaps or write bitmaps, but not both
> at the same time), so support for reuse has no effect - and future users
> can pass around the struct bitmap_index * obtained if they need to do 2
> or more things with the same bitmap.
> [additional paragraph end]
Yeah, that sounds fine to me. Thanks.