Re: [PATCH v2 1/2] t7415: don't bother creating commit for symlink test
- Date: Sat, 9 Jun 2018 11:46:13 +0200
- From: SZEDER Gábor <szeder.dev@xxxxxxxxx>
- Subject: Re: [PATCH v2 1/2] t7415: don't bother creating commit for symlink test
> As a result, there's no need to create a commit in our
> tests. Let's drop it in the name of simplicity.
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> t/t7415-submodule-names.sh | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/t/t7415-submodule-names.sh b/t/t7415-submodule-names.sh
> index a770d92a55..e2aae587ae 100755
> --- a/t/t7415-submodule-names.sh
> +++ b/t/t7415-submodule-names.sh
> @@ -141,7 +141,6 @@ test_expect_success 'fsck detects symlinked .gitmodules file' '
I add few more lines of context here:
printf "100644 blob $content\t$tricky\n" &&
> printf "120000 blob $target\t.gitmodules\n"
> } | git mktree
> ) &&
> - commit=$(git commit-tree $tree) &&
This was the only case where that $tree variable was used, so perhaps
that can go away as well, in the name of even more simplicity?
> # Check not only that we fail, but that it is due to the
> # symlink detector; this grep string comes from the config