Web lists-archives.com

Re: [PATCH v8 1/2] json_writer: new routines to create data in JSON format






On 6/7/2018 1:24 PM, Eric Sunshine wrote:
On Thu, Jun 7, 2018 at 10:12 AM,  <git@xxxxxxxxxxxxxxxxx> wrote:
Add a series of jw_ routines and "struct json_writer" structure to compose
JSON data.  The resulting string data can then be output by commands wanting
to support a JSON output format.
[...]
Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
---
diff --git a/t/t0019-json-writer.sh b/t/t0019-json-writer.sh
@@ -0,0 +1,236 @@
+test_expect_success 'simple object' '
+       cat >expect <<-\EOF &&
+       {"a":"abc","b":42,"c":3.14,"d":true,"e":false,"f":null}
+       EOF
+       test-json-writer >actual \
+               @object \
+                       @object-string a abc \
+                       @object-int b 42 \
+                       @object-double c 2 3.140 \
+                       @object-true d \
+                       @object-false e \
+                       @object-null f \
+               @end &&
+       test_cmp expect actual
+'

To make it easier on people writing these tests, it might be nice for
this to be less noisy by getting rid of "@" and "\". To get rid of
"\", the test program could grab its script commands from stdin (one
instruction per line) rather than from argv[]. For instance:

     test-json-writer >actual <<-\EOF &&
         object
             object-string a abc
             ...
         end
     EOF

Not a big deal, and certainly not worth a re-roll.


I hadn't thought about doing it that way.  Might be a little easier
to use.  Let me take a look and see if it would be much work to switch.

Thanks
Jeff