Web lists-archives.com

Re: [PATCH] config.c: fix regression for core.safecrlf false




On Wed, Jun 6, 2018 at 1:18 PM, Anthony Sottile <asottile@xxxxxxxxx> wrote:
> On Wed, Jun 6, 2018 at 10:17 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
>> On Wed, Jun 6, 2018 at 1:15 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
>>> On Mon, Jun 4, 2018 at 4:17 PM, Anthony Sottile <asottile@xxxxxxxxx> wrote:
>>>> +       for w in I am all CRLF; do echo $w; done | append_cr >allcrlf &&
>>>
>>> Simpler: printf "%s\n" I am all CRLF | append_cr >allcrlf &&
>>
>> Or even simpler:
>>
>> printf "%s\r\n" I am all CRLF >allcrlf &&
>
> Yeah, I just copied the line in my test from another test in this file
> which was doing a ~similar thing. [...]

Thanks for pointing that out. In that case, it's following existing
practice, thus certainly not worth a re-roll.