Re: [PATCH] config.c: fix regression for core.safecrlf false
- Date: Wed, 6 Jun 2018 13:15:54 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] config.c: fix regression for core.safecrlf false
On Mon, Jun 4, 2018 at 4:17 PM, Anthony Sottile <asottile@xxxxxxxxx> wrote:
> A regression introduced in 8462ff43e42ab67cecd16fdfb59451a53cc8a945 caused
> autocrlf rewrites to produce a warning message despite setting safecrlf=false.
> Signed-off-by: Anthony Sottile <asottile@xxxxxxxxx>
> diff --git a/t/t0020-crlf.sh b/t/t0020-crlf.sh
> @@ -98,6 +98,16 @@ test_expect_success 'safecrlf: git diff demotes safecrlf=true to warn' '
> +test_expect_success 'safecrlf: no warning with safecrlf=false' '
> + git config core.autocrlf input &&
> + git config core.safecrlf false &&
I was going to suggest test_config() for these rather than bare
git-config, but I see other tests in this file already use the bare
form, so this is following existing practice.
> + for w in I am all CRLF; do echo $w; done | append_cr >allcrlf &&
Simpler: printf "%s\n" I am all CRLF | append_cr >allcrlf &&
(probably not worth a re-roll)
> + git add allcrlf 2>err &&
> + test_must_be_empty err