Re: [PATCH 5/6] fetch-pack: move common check and marking together
- Date: Tue, 5 Jun 2018 17:01:46 -0700
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH 5/6] fetch-pack: move common check and marking together
Jonathan Tan wrote:
> This enables the calculation of was_common and the invocation to
> mark_common() to be abstracted into a single call to the negotiator API
> (to be introduced in a subsequent patch).
I like it. I think it should be possible to describe the benefit of
this patch without reference to the specifics of the subsequent one.
Maybe something like:
When receiving 'ACK <object-id> continue' for a common commit,
check if the commit was already known to be common and mark it
as such if not up front. This should make future refactoring
of how the information about common commits is stored more
No visible change intended.
> Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
> fetch-pack.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
With or without such a clarification,
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>