Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"
- Date: Sun, 3 Jun 2018 16:33:40 +0100
- From: "Philip Oakley" <philipoakley@xxxxxxx>
- Subject: Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"
From: "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx>
On Sun, 3 Jun 2018, Thomas Gummerer wrote:
> Subject: [PATCH v2] t/perf/run: Use proper "--get-regexp", not
micronit: we prefer starting with a lowercase letter after the "area:"
prefix in commit messages. Junio can probably fix that while
queuing, so no need to resend.
argh, i actually know that, i just screwed up.
On 06/03, Robert P. J. Day wrote:
> Even though "--get-regex" appears to work with "git config", the
> clear standard is to spell out the action in full.
--get-regex works as the parse-option API allows abbreviations of the
full option to be specified as long as the abbreviation is
unambiguos. I don't know if this is documented anywhere other than
it's in `git help cli`:
many commands allow a long option --option to be abbreviated only to their
unique prefix (e.g. if there is no other option whose name begins with opt,
you may be able to spell --opt to invoke the --option flag), but you should
fully spell them out when writing your scripts;
It's a worthwile read, even if the man page isn't flagged up that often.
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
It took me a bit to figure out why there is a v2, and what changed
between the versions. This space after the '---' would be a good
place to describe that to help reviewers.
For others that are curious, it seems like the word "clear" was added
in the commit message.
The change itself looks good to me.
the actual rationale for v2 was in the subject, i originally put
just "get-regex" rather then "--get-regex"; i resubmitted for