Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR
- Date: Sun, 3 Jun 2018 16:29:10 +0200
- From: SZEDER Gábor <szeder.dev@xxxxxxxxx>
- Subject: Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR
Could you please add "in a comment" to the end of the subject line?
So it will be immediately clear to future readers of 'git log
--oneline' that this is not a bugfix.
> Fix single misspelling of $GITDIR to correct $GIT_DIR.
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> only occurrence in entire code base that i ran across, so i figured
> might as well fix it.
> diff --git a/sha1-file.c b/sha1-file.c
> index 555e780f4..695e5c627 100644
> --- a/sha1-file.c
> +++ b/sha1-file.c
> @@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
> * Compute the exact path an alternate is at and returns it. In case of
> * error NULL is returned and the human readable error is added to `err`
> - * `path` may be relative and should point to $GITDIR.
> + * `path` may be relative and should point to $GIT_DIR.
> * `err` must not be null.
> char *compute_alternate_path(const char *path, struct strbuf *err)