Web lists-archives.com

Re: [PATCH v2 04/14] describe: use commit-slab for commit names instead of commit->util




Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> +		slot = commit_names_peek(&commit_names, c);
> +		n = slot ? *slot : NULL;

Seeing this and the helper in the previous step makes me wonder if
we also want a "peek-and-then-peel" variant that encapsulates this
pattern.  We'll know when we read the series through.

So far looking good.  Thanks.

>  		if (n) {
>  			if (!tags && !all && n->prio < 2) {
>  				unannotated_cnt++;