Web lists-archives.com

Re: [PATCH v2 02/14] commit-slab: support shared commit-slab




Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> define_shared_commit_slab() could be used in a header file to define a
> commit-slab. One of these C files must include commit-slab-impl.h and
> "call" implement_shared_commit_slab().
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
> ---
>  commit-slab-hdr.h  | 13 +++++++++++++
>  commit-slab-impl.h | 20 +++++++++++++-------
>  commit-slab.h      |  2 +-
>  3 files changed, 27 insertions(+), 8 deletions(-)

This, while it is a reasonable change, makes the big comment at the
end of commit-slab-impl.h out of sync with the reality, doesn't it?
implement_commit_slab() now takes three args, but the comment still
says the caller does not have to give the third one.