Web lists-archives.com

Re: [PATCH v2 17/28] t4014: abstract away SHA-1-specific constants




Am 13.05.2018 um 04:24 schrieb brian m. carlson:
Adjust the test so that it computes values for blobs instead of using
hard-coded hashes.

Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>
---
  t/t4014-format-patch.sh | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index dac3f349a3..42b3e11207 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -578,7 +578,9 @@ test_expect_success 'excessive subject' '
rm -rf patches/ &&
  	git checkout side &&
+	before=$(git rev-parse --short $(git hash-object file)) &&
  	for i in 5 6 1 2 3 A 4 B C 7 8 9 10 D E F; do echo "$i"; done >>file &&
+	after=$(git rev-parse --short $(git hash-object file)) &&

It would be better to avoid process expansion in command arguments, because the shell does not diagnose failures. This is preferable:

	before=$(git hash-object file) &&
	before=$(git rev-parse --short $before) &&

-- Hannes