Re: [BUG] git send-email: incorrectly parses email address with comma
- Date: Sat, 12 May 2018 23:07:50 +0200
- From: Heinrich Schuchardt <xypron.glpk@xxxxxx>
- Subject: Re: [BUG] git send-email: incorrectly parses email address with comma
On 05/12/2018 11:48 AM, Jeff King wrote:
> On Sat, May 12, 2018 at 10:21:46AM +0200, Heinrich Schuchardt wrote:
>> Git send-email allows to combine multiple email addresses in one
>> parameter, e.g.
>> --to="a@xxxxxxxxxxx, b@xxxxxxxxxxx"
>> But email addresses may contain commas themselves:
>> --to="LASTNAME, firstname <firstname.lastname@xxxxxxxxxxx>"
>> This may lead to an error:
> If the name contains syntactically relevant metacharacters, it can be
> quoted. So as a workaround, you can do:
> --to='"LASTNAME, firstname" <firstname.lastname@xxxxxxxxxxx>'
> I think rfc822 actually requires even names with just spaces in them to
> be quoted, but git-send-email and most other mail programs are pretty
> lax about allowing just about anything outside of the <>, so people tend
> not to bother.
>> If the string preceding a comma is not a valid email address do not
>> split it off.
> That might work as a heuristic, though "is a valid email address" is a
> notoriously hard thing to check. Possibly looking for an "@" would catch
> most common cases, though.
A more elaborate test would be:
A string matching [\S\s]*<\S+@\S+.\S+>\s* is an email address.
A string matching \s*\S+@\S+.\S+\s* is an email address.
Both may need trimming of whitespace.
Any other string is not an email address.