Re: [PATCH] repository: fix free problem with repo_clear(the_repository)
- Date: Thu, 10 May 2018 09:34:12 -0700
- From: Stefan Beller <sbeller@xxxxxxxxxx>
- Subject: Re: [PATCH] repository: fix free problem with repo_clear(the_repository)
On Thu, May 10, 2018 at 2:27 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Stefan Beller <sbeller@xxxxxxxxxx> writes:
>> So this would go with the latest sb/object-store-alloc ?
>> My impression was that we never call repo_clear() on
>> the_repository, which would allow us to special case
>> the_repository further just as I did in v2 of that series by
>> having static allocations for certain objects in case of \
>>  https://public-inbox.org/git/20180501213403.14643-14-sbeller@xxxxxxxxxx/
>> We could just deal with all the exceptions, but that makes repo_clear
>> ugly IMHO.
> So perhaps
> void repo_clear(...)
> + if (repo == the_repository)
> + BUG("repo_clear() called on the repository");
> or something?
This would work, but Duy convinced me to have repo_clear working
on the_repository is a good idea by giving a minimal test helper,
which helped me to find leaks, so I'd rather go with the solution
by Duy in  from a developers perspective.