Re: [PATCH] t5310-pack-bitmaps: make JGit tests work with GIT_TEST_SPLIT_INDEX
- Date: Thu, 10 May 2018 10:34:33 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] t5310-pack-bitmaps: make JGit tests work with GIT_TEST_SPLIT_INDEX
On Thu, May 10, 2018 at 03:58:52PM +0200, SZEDER Gábor wrote:
> The two JGit tests 'we can read jgit bitmaps' and 'jgit can read our
> bitmaps' in 't5310-pack-bitmaps.sh' fail when run with
> GIT_TEST_SPLIT_INDEX=YesPlease. Both tests create a clone of the test
> repository to check bitmap interoperability with JGit. With split
> indexes enabled the index in the clone repositories contains the
> 'link' extension, which JGit doesn't support and, consequently, an
> exception aborts it:
> org.eclipse.jgit.api.errors.JGitInternalException: DIRC extension 'link' not supported by this version.
> at org.eclipse.jgit.dircache.DirCache.readFrom(DirCache.java:562)
> Since testing bitmaps doesn't need a worktree in the first place,
> let's just create bare clones for the two JGit tests, so the cloned
> won't have an index, and these two tests can be executed even with
> split index enabled.
Nice, this seems like a clever workaround.
Reviewed-by: Jeff King <peff@xxxxxxxx>
The more heavy-handed approach would be to just disable the JGIT prereq
when GIT_TEST_SPLIT_INDEX is in use, which would cover this and
potentially any other cases. This is nicer because it lets us continue
using the test. And it's not like we have a ton of jgit dependencies,
such that dealing with each individually would be a burden.