Re: regarding fix on "git clone $there $here"
- Date: Wed, 9 May 2018 02:41:32 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: regarding fix on "git clone $there $here"
On Tue, May 08, 2018 at 10:25:58PM -0700, Leslie Wang wrote:
> Recently we try to upgrade ubuntu from 17.10 to 18.04, then we found
> one inconsistent behavior on git clone.
> At 2.14.1 or 2.15.1, if I run command like
> - mkdir /tmp/111
> - git clone git@xxxxxxxxxx:111/111 /tmp/111
> because it will failure, then /tmp/111 will be removed automatically.
> However, at latest 2.17.0 which is part of ubuntu 18.04, seems like
> git clone failure will not auto remove this folder. I notice 2.16.2
> and 2.17.0 release note includes this fix. So just wonder to know if
> prior behavior was think of bug, and this fix has change the behavior.
> * "git clone $there $here" is allowed even when here directory exists
> as long as it is an empty directory, but the command incorrectly
> removed it upon a failure of the operation.
Right, the old behavior was considered a bug. Git didn't create the
directory, so when rolling back its changes on failure, it shouldn't
delete it either.