Web lists-archives.com

Re: [PATCH 00/28] Hash-independent tests (part 2)




On Sun, May 06, 2018 at 09:49:45PM -0400, Eric Sunshine wrote:
> On Sun, May 6, 2018 at 7:17 PM, brian m. carlson
> <sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
> > This series introduces an SHA1 prerequisite which checks if the hash in
> > use is SHA-1, and can be used to skip the test if it is not.
> > Additionally, because NewHash will be 256-bit, I introduced aliases for
> > the test constants $_x40 and $_z40 which will be less confusing when the
> > hash isn't 40 hex characters long.  I opted to leave the old names in
> > place for the moment to prevent any potential conflicts with other
> > series and will clean up any stragglers later.
> >
> > Several tests are skipped because of SHA-1-specific dependencies: some
> > of these are core tests which test basic expected hash values, some
> > depend on colliding short names, and some depend on specially named
> > object (the pack tests).
> 
> Was I wrong to expect this series to annotate[1] tests
> 
>     t3404 "short SHA-1 setup"
>     t3404 "short SHA-1 collide"
> 
> with the SHA1 prerequisite?

t3404 is in the next series.  I realize it's slightly out of order, but
I tended to fix them in roughly the order they showed up in parallel
test output, which is why it's in the next series.  There are some more
involved ones which ended up in the next series as well.

I figured reviewers would appreciate a shorter series over a longer one.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

Attachment: signature.asc
Description: PGP signature