Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)
- Date: Tue, 10 Apr 2018 07:08:55 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)
Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:
> On 09/04/18 14:37, Derrick Stolee wrote:
>> On 4/9/2018 6:21 AM, Junio C Hamano wrote:
>>> * ds/commit-graph (2018-04-02) 16 commits
>>> - commit-graph: implement "--additive" option
>>> It seems that this topic is getting there.
>> I think this patch is ready to go, barring ...
> Also, it seems that the 'static' keyword has been dropped from the
> declaration of 'commit_graph' (commit-graph.c #183) again:
> $ diff nsp-out psp-out
> > SP chdir-notify.c
> > SP commit-graph.c
> > commit-graph.c:183:21: warning: symbol 'commit_graph' was not declared. Should it be static?
> > SP json-writer.c
> > SP builtin/commit-graph.c
> > builtin/commit-graph.c:34:38: warning: Using plain integer as NULL pointer
> < fast-import.c:303:40: warning: Using plain integer as NULL pointer
> > SP t/helper/test-json-writer.c
> > SP t/helper/test-print-larger-than-ssize.c
I guess we'd want a final cleaned-up round after all ;-) Thanks.