Re: [RFC PATCH 1/1] completion: Load completion file for external subcommand
- Date: Mon, 9 Apr 2018 21:49:55 +0200
- From: Florian Gamböck <ml@xxxxxxxx>
- Subject: Re: [RFC PATCH 1/1] completion: Load completion file for external subcommand
On 2018-04-09 11:26, Stefan Beller wrote:
Since bash-completion started to use dynamical loading of completion
scripts somewhere around v2.0, it is no longer sufficient to drop a
completion script of a subcommand into the standard completions path,
/usr/share/bash-completion/completions, since this script will not be
loaded if called as a git subcommand.
Also v1.90 here? (hint from the cover letter, please be exact)
Yes, it started at 1.90. I will reword the commit message and be more
exact in the next iteration.
If Gits own completion script would be broken up by subcommand, would
that also deliver an improvement in performance?
As it is now, the completion script is quite big. On a system with
limited resources, the initial loading time can be long and the memory
footprint is big, given that most users will just use a few commands. If
you just use the "commit" subcommand, the first loading of the two
(smaller) scripts will be slightly longer the first time (but not as
long as with one big script, I think), but the footprint will be
drastically lower. The whole script is 56kB big (without comments),
after radically removing everything which is not connected to
_git_commit, it is only 11kB.
So to answer your question: Yes. My first intuition is, that by
splitting the completion script and loading the sub-scripts dynamically,
it will improve in terms of speed and overall memory footprint, at least
for the average user that does not fire up all possible git commands.