Re: [PATCH] t5404: relax overzealous test
- Date: Mon, 9 Apr 2018 15:52:42 +0200 (DST)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH] t5404: relax overzealous test
On Mon, 9 Apr 2018, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
> > On Fri, Apr 06, 2018 at 09:31:22PM +0200, Johannes Schindelin wrote:
> >> In 0b294c0abf0 (make deleting a missing ref more quiet, 2008-07-08), we
> >> added a test to verify that deleting an already-deleted ref does not
> >> show an error.
> > Amazing that it took this long to come up.
> > ...
> >> This patch chooses instead to look for the prefix "error:" at the
> >> beginning of the line, so that there can be no ambiguity that any catch
> >> was indeed a message generated by Git's `error_builtin()` function.
> > Yep, this seems obviously correct.
> Hits in
> $ git grep 'grep ["'\'']*error' t
> shows that many checks for errors that are not anchored, but I do
> not think any of them are looking for the string in a pathname other
> than this instance, so it would be OK.
Yes, they are okay, I did run the entire test suite in a worktree with the
same name as my branch name: fix-t5404-error.