Re: [PATCH] Fix condition for redirecting stderr
- Date: Sun, 8 Apr 2018 22:23:04 -0400
- From: Todd Zullinger <tmz@xxxxxxxxx>
- Subject: Re: [PATCH] Fix condition for redirecting stderr
Lucas Werkmeister wrote:
> Since the --log-destination option was added in 0c591cacb ("daemon: add
> --log-destination=(stderr|syslog|none)", 2018-02-04) with the explicit
> goal of allowing logging to stderr when running in inetd mode, we should
> not always redirect stderr to /dev/null in inetd mode, but rather only
> when stderr is not being used for logging.
Perhaps 's/^F/daemon: f/' on the subject? (Junio may well
already have done so while queueing locally.)
The patch itself looks reasonable (to my relatively untrained eyes).
Hardware: the parts of a computer that can be kicked.
-- Jeff Pesis