Re: [PATCH v1 1/2] perf/run: add --subsection option
- Date: Sun, 8 Apr 2018 05:44:58 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH v1 1/2] perf/run: add --subsection option
On Sun, Apr 8, 2018 at 5:35 AM, Christian Couder
> This new option makes it possible to run perf tests as defined
> in only one subsection of a config file.
> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
> diff --git a/t/perf/run b/t/perf/run
> @@ -1,21 +1,34 @@
> +while [ $# -gt 0 ]; do
I was going to ask if you meant to use 'test' here rather than '[',
however, I see that this script already has a mix of the two, so...
Likewise, scripts in Git usually omit the semicolon and place 'do' on
its own line, however, again I see that this script has a mix of the
two styles, so...