Re: FREAD_READS_DIRECTORIES test fails for the wrong reasons
- Date: Fri, 6 Apr 2018 18:07:36 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: FREAD_READS_DIRECTORIES test fails for the wrong reasons
On Fri, Apr 06, 2018 at 05:57:15PM -0400, Jonathan Primrose wrote:
> > Oops. This is due to my 3adf9fdecf (configure.ac: loosen
> > FREAD_READS_DIRECTORIES test program, 2017-06-14).
> > Neither I nor the original tester noticed, because we're on Linux, which
> > needs that set.
> I'm also running Linux, but somehow I ended up needing to check
> config.log and saw the error. I don't remember why I had to check.
> (I've been fixing the problem locally for the last few releases,
> figuring someone else would notice. I also remove the 'rm configure'
> from the distclean target in Makefile, just in case I decide to
> rebuild later.)
I think you'll find that most of the developers don't actually use
autoconf themselves, so bugs tend to go unnoticed there for a while.
(The failure case for setting this flag accidentally is not bad, either;
it just incurs an extra fstat).