Re: [PATCH] specify encoding for sed command
- Date: Thu, 5 Apr 2018 05:42:03 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [PATCH] specify encoding for sed command
On Thu, Apr 5, 2018 at 2:53 AM, Ævar Arnfjörð Bjarmason
> On Thu, Apr 05 2018, Stephon Harris wrote:
>> Fixes issue with seeing `sed: RE error: illegal byte sequence` when running git-completion.bash
> This is getting closer to the issue than your previous patch, but
> there's still some open questions:
> 1) What platform OS / version / sed version is this on?
> 2) What's the output from "set" that's causing this error? Do we have an
> isolated test case for that?
> 3) There's other invocations of "sed" in the file, aren't those affected
> as well?
> 4) Any reason we wouldn't just set LC_AlL=C for the whole file? I see we
> already do it for our invocation to "git merge".
Also, missing Signed-off-by: (see Documentation/SubmittingPatches).