Web lists-archives.com

Re: [PATCH v5 2/5] stash: convert apply to builtin




On Thu, Apr 5, 2018 at 9:59 AM, Christian Couder
<christian.couder@xxxxxxxxx> wrote:
> On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder
> <christian.couder@xxxxxxxxx> wrote:
>>
>> So maybe we can get rid of `result` and have something like:
>>
>>        if (argc < 1) {
>>                error(_("at least one argument is required"));
>>                usage_with_options(git_stash_helper_usage, options);
>
> Maybe we could also simplify these 2 lines by using usage_msg_opt().
>
>>        }
>>
>>        if (!strcmp(argv[0], "apply"))
>>                return apply_stash(argc, argv, prefix);
>>
>>        error(_("unknown subcommand: %s"), argv[0]);
>>        usage_with_options(git_stash_helper_usage, options);

And here actually we could improve the above 2 lines using something like:

usage_msg_opt(xstrfmt(_("unknown subcommand: %s"), argv[0]),
                              git_stash_helper_usage, options);

It's better than using `error()` because the printed message will
start with "fatal" instead of "error".