Re: [PATCH v5 2/5] stash: convert apply to builtin
- Date: Thu, 5 Apr 2018 09:59:39 +0200
- From: Christian Couder <christian.couder@xxxxxxxxx>
- Subject: Re: [PATCH v5 2/5] stash: convert apply to builtin
On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder <christian.couder@xxxxxxxxx> wrote: > > So maybe we can get rid of `result` and have something like: > > if (argc < 1) { > error(_("at least one argument is required")); > usage_with_options(git_stash_helper_usage, options); Maybe we could also simplify these 2 lines by using usage_msg_opt(). > } > > if (!strcmp(argv[0], "apply")) > return apply_stash(argc, argv, prefix); > > error(_("unknown subcommand: %s"), argv[0]); > usage_with_options(git_stash_helper_usage, options); > }
- Follow-Ups:
- Re: [PATCH v5 2/5] stash: convert apply to builtin
- From: Christian Couder
- Re: [PATCH v5 2/5] stash: convert apply to builtin
- References:
- [PATCH v5 0/5] Convert some stash functionality to a builtin
- From: Joel Teichroeb
- [PATCH v5 2/5] stash: convert apply to builtin
- From: Joel Teichroeb
- Re: [PATCH v5 2/5] stash: convert apply to builtin
- From: Christian Couder
- [PATCH v5 0/5] Convert some stash functionality to a builtin
- Prev by Date: Re: [PATCH v3] git-svn: allow empty email-address using authors-prog and authors-file
- Next by Date: Re: [PATCH v5 2/5] stash: convert apply to builtin
- Previous by thread: Re: [PATCH v5 2/5] stash: convert apply to builtin
- Next by thread: Re: [PATCH v5 2/5] stash: convert apply to builtin
- Index(es):