Re: [PATCH 0/2] Make cvs tests pass with '-x' tracing and /bin/sh
- Date: Mon, 12 Mar 2018 20:05:12 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 0/2] Make cvs tests pass with '-x' tracing and /bin/sh
On Thu, Mar 08, 2018 at 01:38:42PM +0100, SZEDER Gábor wrote:
> > I installed 'cvs' and whatnot to run t94* and t96* tests, and sure
> > enough, 5 tests in 2 test scripts fail with '-x' tracing and /bin/sh.
> > I think I will be able to get around to send v2 during the weekend.
> Well, I wasn't able to get around to it, and in the meantime
> 'sg/test-x' got merged into 'next'. So here are the updates for those
> two test scripts.
> The commit message of the first patch is perhaps unnecessary long, but
> it's mostly about explaining why the affected test was working
> reasonably well despite the rather weird 'test_cmp this that >>out
> 2>&1' thing.
You know I would never complain about a long commit message. :)
Both patches look OK to me. My only comment on the first one was "you
should just use 'return'", but I see Eric beat me to it.
I do think the postimage of the second one is a little less readable.
That's not a big deal to me, but I'm pretty sure I would intentionally
write it the "original" way if I found myself in a similar situation.
Which makes me wonder whether we'll end up accidentally re-introducing
these kinds of "-x" failures. But as I said before, I'm willing to wait