Re: What's cooking in git.git (Mar 2018, #02; Tue, 6)
- Date: Fri, 9 Mar 2018 16:54:05 +0700
- From: Duy Nguyen <pclouds@xxxxxxxxx>
- Subject: Re: What's cooking in git.git (Mar 2018, #02; Tue, 6)
On Fri, Mar 9, 2018 at 1:15 PM, Martin Ågren <martin.agren@xxxxxxxxx> wrote:
> On 7 March 2018 at 00:34, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> * ma/config-page-only-in-list-mode (2018-02-21) 3 commits
>> - config: change default of `pager.config` to "on"
>> - config: respect `pager.config` in list/get-mode only
>> - t7006: add tests for how git config paginates
>> In a way similar to how "git tag" learned to honor the pager
>> setting only in the list mode, "git config" learned to ignore the
>> pager setting when it is used for setting values (i.e. when the
>> purpose of the operation is not to "show").
>> Is this ready for 'next'?
> I am not aware of any open questions or issues. You thought out loud
> about how the series was structured, in particular about introducing a
> successful test, then redefining it, as opposed to introducing it as a
> failing test, then making it succeed. I hope I managed to motivate my
> choice better in v2 (which is what you have picked up).
> Duy wondered if it was sane to use a pager when we know that we are
> "--get"-ing at most one config item. In v2, I addressed this by turning
> on paging for a more careful selection of "--get"-ters.
Yeah I got busy with stuff and didn't look at it. I've just checked
what's in 'pu'. Looks good to me.