Re: [PATCH v2 1/5] fixup! Add a test showing that 'git repack' throws away grafted-away parents
- Date: Tue, 06 Mar 2018 10:01:51 -0800
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v2 1/5] fixup! Add a test showing that 'git repack' throws away grafted-away parents
Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:
> The closing quote of a test body by convention is always at the start
> of line.
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
Obviously correct. While the title may technically be correct, the
original commit is age old that we won't be amending it anyway, and
it is not very helpful not to say which aspect of the original is
being fixed up. Perhaps something like:
t7700: have closing quote of a test at the beginning of line
1ec64827 ("Add a test showing that 'git repack' throws away
grafted-away parents", 2009-07-23) added this test but indented
the closing quote by mistake.
if we really cared documenting where the blame lies, but I do not
think it is quite worth it; anybody who cares deeply can ask "git
blame" about it, so I'll just retitle and use your original log
> t/t7700-repack.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh
> index 6061a04147..38247afbec 100755
> --- a/t/t7700-repack.sh
> +++ b/t/t7700-repack.sh
> @@ -194,7 +194,7 @@ test_expect_success 'objects made unreachable by grafts only are kept' '
> git reflog expire --expire=$test_tick --expire-unreachable=$test_tick --all &&
> git repack -a -d &&
> git cat-file -t $H1
> - '