Re: [PATCH 00/11] Moving global state into the repository object (part 2)
- Date: Sat, 3 Mar 2018 09:54:15 +0700
- From: Duy Nguyen <pclouds@xxxxxxxxx>
- Subject: Re: [PATCH 00/11] Moving global state into the repository object (part 2)
On Thu, Mar 1, 2018 at 2:09 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Stefan Beller <sbeller@xxxxxxxxxx> writes:
>> On Wed, Feb 28, 2018 at 9:59 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> Duy Nguyen <pclouds@xxxxxxxxx> writes:
>>>> Looking at the full-series diff though, it makes me wonder if we
>>>> should keep prepare_packed_git() private (i.e. how we initialize the
>>>> object store, packfile included, is a private matter). How about
>>>> something like this on top?
>>> Yup, that looks cleaner.
>> I agree that it looks cleaner. So we plan on just putting
>> it on top of that series?
> We tend to avoid "oops, that was wrong and here is a band aid on
> top" for things that are still mushy, so it would be preferrable to
> get it fixed inline, especially if there are more changes to the
> other parts of the series coming.
I agree with this. Stefan, if you're getting bored with rerolling
refactor patches, I can update this series and send out v2.