Re: What's cooking in git.git (Mar 2018, #01; Thu, 1)
- Date: Fri, 2 Mar 2018 18:39:39 +0100
- From: Lars Schneider <larsxschneider@xxxxxxxxx>
- Subject: Re: What's cooking in git.git (Mar 2018, #01; Thu, 1)
> On 02 Mar 2018, at 18:11, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Junio C Hamano <gitster@xxxxxxxxx> writes:
>> SZEDER Gábor <szeder.dev@xxxxxxxxx> writes:
>>> On Thu, Mar 1, 2018 at 11:20 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>>> * sg/travis-build-during-script-phase (2018-01-08) 1 commit
>>>> - travis-ci: build Git during the 'script' phase
>>>> Stalled for too long without any response; will discard.
>>> I still think this is a good change as-is and it does make checking the
>>> results of Travis CI builds easier. The issue Lars raised in  is in
>>> my opinion a non-issue  in practice and Lars hasn't yet disagreed
>>> with that.
>> OK, so I simply misread the discussion and did not realize that it
>> reached a conclusion? If that's the case, good ;-). Thanks.
> OK, I think I now understand what happened. I misread the "fold"
> discussion and thought we were still exploring the possibility, to
> avoid showing uninteresting zero-status case to the users.
> If we do not care about that part, then it seems that the discussion
> thread is complete. Let's move on.
All good with me. I just wanted explain my reasoning for the initial
implementation. I do understand Szeder's reasoning too and I am OK
with the change.
Thanks for improving the TravisCI integration Szeder!